[node] - Node 18 EOL changes #1349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathiyarasy
approved these changes
Apr 30, 2025
eljog
requested changes
Jun 2, 2025
test/node/install_additional_node.sh
Outdated
| @@ -6,7 +6,7 @@ set -e | |||
| source dev-container-features-test-lib | |||
|
|
|||
| # 'lts' is now some version of node 20... | |||
| @@ -6,7 +6,7 @@ set -e | |||
| source dev-container-features-test-lib | |||
|
|
|||
| # 'lts' is now some version of node 20... | |||
| check "version_on_path" node -v | grep 20 | |||
| check "version_on_path" node -v | grep 22 | |||
| @@ -6,7 +6,7 @@ set -e | |||
| source dev-container-features-test-lib | |||
|
|
|||
| # 'lts' is now some version of node 20... | |||
| check "version_on_path" node -v | grep 20 | |||
| check "version_on_path" node -v | grep 22 | |||
| check "pnpm" bash -c "pnpm -v | grep 6.16.0" | |||
|
|
|||
| check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: devcontainers/images#90
Description: Node 18 EOL on Apr 30th 2025 for the node devcontainer feature.
Changelog:
Checklist: